Update the traintainer weight to be less
What does this MR do and why?
Currently the review weights look like this when comparing regular reviewers to traintainers:
# +------------------------------+--------------------------------+
# | reviewer type | weight(times in reviewer pool) |
# +------------------------------+--------------------------------+
# | reduced capacity reviewer | 1 |
# | reviewer | 2 |
# | hungry reviewer | 4 |
# | reduced capacity traintainer | 3 |
# | traintainer | 6 |
# | hungry traintainer | 8 |
# +------------------------------+--------------------------------+
This seems a bit unfair to couple being a traintainer with even more workload in reviews. While that may be the desire at times, it isn't always and can lead to a traintainer feeling overwhelmed and thus setting status to
So we'll look to change this weighting so that we can still super charge a traintainer when desired, but when not, have their weight match regular reviewers.
# +------------------------------+--------------------------------+
# | reviewer type | weight(times in reviewer pool) |
# +------------------------------+--------------------------------+
# | reduced capacity reviewer | 1 |
# | reviewer | 2 |
# | hungry reviewer | 4 |
# | reduced capacity traintainer | 1 |
# | traintainer | 2 |
# | hungry traintainer | 6 |
# +------------------------------+--------------------------------+
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Doug Stull