Skip to content

Add and use default reviewer roulette

Matthias Käppler requested to merge mk-use-defaults into master

What does this MR do and why?

Taking a first stab here at making it easier for new projects to include default rules and plugins, plus a simple reviewer roulette. Currently, every project at GitLab must copy a Dangerfile and other code around for that to happen.

This MR makes gitlab-dangerfiles "eat its own dog food" as well and uses this roulette file.

I also made some minor changes to how imports are accessed, since I found that exposing the Engine instance felt a bit "low-level" for a convenient API. I added Gitlab::Dangerfiles.for_project instead which yields an engine instance to a block, on which we can then perform imports.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Matthias Käppler

Merge request reports