Skip to content

Fixes a warning about kwargs

Jeremy Jackson requested to merge jj-fix-deprecation-warning into master

I saw this in the build output of https://gitlab.com/gitlab-org/gitlab/-/jobs/906743633#L143

DEPRECATION WARNING: gitlab-experiment-0.4.3/lib/gitlab/experiment.rb:63: warning: Using the last argument as keyword
parameters is deprecated; maybe ** should be added to the call gitlab-experiment-0.4.3/lib/gitlab/experiment/context.rb:10:
warning: The called method `initialize' is defined here.

I actually couldn't seem to get this to reproduce locally, but updated ruby anyway. I assume the call to Context.new and passing in a hash instead of kwargs was what the warning was about. Interesting to learn about.

Edited by Jeremy Jackson

Merge request reports