Update RuboCop to 1.43.0 and RuboCop RSpec
What does this MR do and why?
- RuboCop 1.43.0 - https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#1430-2023-01-10
- RuboCop GraphQL 0.18 - https://github.com/DmitryTsepelev/rubocop-graphql/blob/master/CHANGELOG.md#0180-2022-10-30
- RuboCop Performance 1.15 - https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md#1152-2022-12-25
- RuboCop Rails 2.17 - https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md#2174-2022-12-25
- RuboCop RSpec 2.16 - https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md#2160-2022-12-13
With the upgrade of RuboCop we can remove our custom RuboCop patches.
See gitlab-org/gitlab#377469 (comment 1231865207) and https://github.com/rubocop/rubocop/pull/11247#issuecomment-1375579325.
Updating other RuboCop gems explicitly makes sense because they are already used in gitlab-org/gitlab
implicitly:
$ rg "rubocop-\S+ \(\d+" Gemfile.lock
1280: rubocop-ast (1.24.1)
1282: rubocop-gitlab-security (0.1.1)
1284: rubocop-graphql (0.18.0)
1286: rubocop-performance (1.15.2)
1289: rubocop-rails (2.17.4)
1293: rubocop-rspec (2.16.0)
gitlab/gitlab-org
Testing on
Edited by Peter Leitzen