Skip to content

Fix a swallowed error and properly raise StandardError exceptions

Rémy Coutable requested to merge fix-main-error into main

What does this MR do and why?

This missing line in tests was causing the tests to fail since client.issue_notes/client.issue_discussions would return nil, which doesn't reply to #auto_paginate. In this case the test were wrong (not the implementation).

I also made GitlabClient#handle_gitlab_client_exceptions raise StandardError after it rescues these errors, otherwise it could swallow legit bugs.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rémy Coutable

Merge request reports

Loading