Skip to content

Default section_sets and fix lefthook check on first commit

Sanad Liaquat requested to merge shl-fix-nil-section-sets into main

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR:

  1. Fixes an issue where an uninitialised @section_sets may cause undefined method 'any?' for nil:NilClass (NoMethodError) such has here: https://gitlab.com/gitlab-org/quality/toolbox/-/jobs/6391383150
  2. Fixes an issue if a user hasn't updated their ref to main recently may cause the changelog-on-first-commit lefthook check to incorrectly pass. See this MR for details: gitlab-org/gitlab-qa!1288 (merged)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sanad Liaquat

Merge request reports