Skip to content

Fixes skip reporting for ignored failures when multiple failures occur

Désirée Chevalier requested to merge fix-skip-reporting-ignored-failure into main

What does this MR do and why?

Fixes a bug that happens when there are multiple failures for a test and the first one is an ignored exception. We currently create failure issues with the first failure. This change checks the first failure and skips to the second when the first is an ignored exception.

Example bug: gitlab-org/gitlab#416544 (closed)

In this example, there were two failures, Net::ReadTimeout and QA::Support::PageErrorChecker::PageError. Net::ReadTimeout is in the IGNORED_FAILURES list and would normally not be reported but because there was more than one error and only one was on the ignore list, the test failure is reported. In our current setup, we always grab the first error for the stacktrace, in this case, it was the ignored error.

This MR now checks the error against the ignore list and moves on to the next if it matches.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports