Skip to content

Prevents private titles/points from being shown in public topics

James Johnson requested to merge 5-confidential_private_boundary into master

A situation could exist where topics and points from a private topic are shown in the summary of a public topic. This can happen as either:

  • public root topic showing contents of a private sub topic
  • private root topic title being shown in the link ROOT summary link in a public topic summary

Checklist

  • Manually verified passing unit tests for this branch locally by running bin/run_docker_tests.sh
    • Yes, this is a pain, but GitLab doesn't run reasonably within a docker container in a normal CI pipeline
    • See bin/run_docker_tests.sh --help for faster/iterative testing options
  • Paste local test output

Local Test Output

/bin/run_docker_tests.sh output 
[>>>] Will not kill docker container (can be re-used)
[>>>] Retrieving token
[>>>] GitLab should be ready
[>>>] Pasteable config into bin/.env: 
[>>>] 
export DISCOTO_GITLAB_ENDPOINT=http://172.17.0.3
export DISCOTO_GITLAB_TOKEN=B7EwjHFFhMYJqjCcc-fW
export DISCOTO_PROJECTS=test-group/test-project
export DISCOTO_GROUPS=test-group
export DISCOTO_ISSUABLE_ASSIGNEE=
export DISCOTO_ISSUABLE_AUTHOR=
export DISCOTO_ISSUABLE_LABELS=discoto
[>>>] 
[>>>] Running tests on 5-confidential_private_boundary @ 220c80b72e0eab6ba25f55ae5460bfba60a0067e
warning: parser/current is loading parser/ruby27, which recognizes
warning: 2.7.1-compliant syntax, but you are running 2.7.2.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
...........................................

Finished in 1 minute 58.47 seconds (files took 0.38258 seconds to load)
43 examples, 0 failures

Coverage report generated for RSpec to /home/james/ws/dev/gitlab/discussion-automation/coverage. 591 / 691 LOC (85.53%) covered.
[>>>] Cleaning up
[>>>] Cleaning up

Closes #5 (closed)

Edited by James Johnson

Merge request reports