Skip to content

Now correctly strips quick actions from notes

James Johnson requested to merge 20-recursive_sub_topics into master

Fixes #20 (closed)

Discoto was stripping /discuss quick actions from note bodies but wasn't using the sanitized result when copying notes from one thread into another.

Checklist

  • Manually verified passing unit tests for this branch locally by running bin/run_docker_tests.sh
    • Yes, this is a pain, but GitLab doesn't run reasonably within a docker container in a normal CI pipeline
    • See bin/run_docker_tests.sh --help for faster/iterative testing options
  • Paste local test output

Local Test Output

/bin/run_docker_tests.sh output
 lptp [ discussion-automation ]: bin/run_docker_tests.sh --no-kill
[>>>] Will not kill docker container (can be re-used)
[>>>] Retrieving token
[>>>] GitLab should be ready
[>>>] Pasteable config into bin/.env: 
[>>>] 
export DISCOTO_GITLAB_ENDPOINT=http://172.17.0.2
export DISCOTO_GITLAB_TOKEN=J7oR-BpcL48SFmKp26ga
export DISCOTO_PROJECTS=test-group/test-project
export DISCOTO_GROUPS=test-group
export DISCOTO_ISSUABLE_ASSIGNEE=
export DISCOTO_ISSUABLE_AUTHOR=
export DISCOTO_ISSUABLE_LABELS=discoto
[>>>] 
[>>>] Running tests on 20-recursive_sub_topics @ 5769ef0d2810b2aa762a9497967a8a0f538ffe2f
warning: parser/current is loading parser/ruby27, which recognizes
warning: 2.7.1-compliant syntax, but you are running 2.7.2.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
.............................................

Finished in 2 minutes 15.7 seconds (files took 0.37014 seconds to load)
45 examples, 0 failures

Coverage report generated for RSpec to /home/james/ws/dev/gitlab/discussion-automation/coverage. 590 / 690 LOC (85.51%) covered.
[>>>] Cleaning up
[>>>] Cleaning up

Closes #20 (closed)

Edited by James Johnson

Merge request reports

Loading