Fix incorrect regex, SASTBot updates
What does this MR do?
EDIT: merged in !268 (merged) to simplify conflicts
GitLab pipeline trigger tokens are actually 40 bytes, since it's a hexified string:
irb(main):005> puts SecureRandom.hex(20).length
40
Slack token incorrectly includes ?
on end of regex, meaning we'd match "xoxb-":
- Example showing incorrect match: https://go.dev/play/p/YG40JC4Ka7b
- Real world list of incorrect matches: https://grep.app/search?q=xox%5Bbaprs%5D-%28%5B0-9a-zA-Z%5D%7B10%2C48%7D%29%3F®exp=true
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests updated/added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Lucas Charles