Update helper functions in convert to be more generic, add eslint mappings
What does this MR do?
This MR adds eslint identifiers that match the eslint analyzer. This is accomplished by prefacing rules.id
in rules/eslint.yml
with eslint
, similar to the bandit rules. Additionally, some of the helper functions in convert.go
have been updated to be more generic.
What are the relevant issue numbers?
gitlab-org/gitlab#322194 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Zach Rice