Skip to content

Consistent exception handling

Cameron Swords requested to merge consistent-exception-handling into master

What does this MR do?

Handle errors thrown by DAST using a consistent strategy:

  • Rename DASTExceptionHandler to DASTErrorHandler
  • The only class to call logger.error should be the DASTErrorHandler
  • The DASTErrorHandler defines exception types that should be logged without a stacktrace
  • The ScanScriptWrapper should not call system.exit
  • Error types are fairly general, the message in the constructor is very specific

What are the relevant issue numbers?

gitlab-org/gitlab#214240 (closed)

Does this MR meet the acceptance criteria?

Edited by Cameron Swords

Merge request reports

Loading