Skip to content

Fix shell script bugs

Sarah German requested to merge setup-script-fixes into main

What does this MR do and why?

First bugs of the project! 😀

Couple minor fixes:

  • Remove colors.sh. It stopped working at some point. Let's drop it for now and just stick to using colors for output from the Makefile
  • Adds an if to skip over lines with code comments in .tool-versions when we read that file as part of local env setup
  • Makes variables ALLCAPS in the bash script. This is easier to read in bash.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Run make setup. You should no longer see errors like this:
/opt/homebrew/opt/asdf/libexec/bin/asdf
# is invalid. Name may only contain lowercase letters, numbers, '_', and '-'
No such plugin: #
# is invalid. Name may only contain lowercase letters, numbers, '_', and '-'
No such plugin: #

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports