Skip to content

Fix active menu trail for extensionless URLs

Sarah German requested to merge active-menu-item into main

What does this MR do and why?

The active menu trail does not highlight for all paths where the page can be accessed:

This MR adjusts the active item logic so that it should work for any of these possible paths.

This also adjusts nav-related tests to better reflect the change to uglyURLs in !139 (merged).

This MR also includes a fix for a typo introduced in !143 (diffs). The new site is new.docs.gitlab.com, not new.gitlab.com 🤦.

How to set up and validate locally

n/a, can't test this locally

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sarah German

Merge request reports

Loading