Skip to content

Resolve "Visual regression: pagination on search results page"

What does this MR do and why?

This MR fixes the pagination styling in search results page. The stylings were a bit off compared to the GitLab UI styles here https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/base-pagination--docs for pagination component.

Screenshots, screen recordings, or links to review app

BEFORE AFTER
image image
image image

Recording:

pagination-style-fix

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/technical-writing-group/gitlab-docs-hugo/-/blob/main/doc/setup.md.
  2. Run make view and search something on the search bar (landing page). This should take you to the results page. No logic change is expected. Styling should match the GitLab UI component.

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #149 (closed)

Edited by Hiru Fernando

Merge request reports

Loading