Copy check_mocks target from gitlab-runner project
What does this MR do?
Updates the check_mocks
target to match the one from the gitlab-runner project, and adds a missing mock file that went undetected.
Why was this MR needed?
New mock files that are missing were not detected by check_mocks
without these changes.
What's the best way to test this MR?
Locally revert the last commit that adds the missing mock file ✅
The following script should fail:
$ git revert --no-edit HEAD && make check_mocks
# Checking if mocks are up-to-date
# Removing existing mocks
# Generating new mocks
Generating mock for: CacheStore in file: mocks/providers/CacheStore.go
Generating mock for: Client in file: mocks/executors/winrm/Client.go
Generating mock for: Client in file: mocks/internal/orka/Client.go
Generating mock for: Encoder in file: mocks/internal/encoding/Encoder.go
Generating mock for: Env in file: mocks/internal/env/Env.go
Generating mock for: Executor in file: mocks/executors/Executor.go
Generating mock for: FS in file: mocks/internal/fs/FS.go
Generating mock for: Handler in file: mocks/internal/cli/Handler.go
Generating mock for: Logger in file: mocks/internal/logging/Logger.go
Generating mock for: Provider in file: mocks/providers/Provider.go
Generating mock for: Storage in file: mocks/internal/logging/storage/Storage.go
Generating mock for: customCommand in file: mocks/cmd/autoscaler/commands/custom/customCommand.go
Generating mock for: Client in file: internal/mocks/orka/Client.go
Generating mock for: Encoder in file: internal/mocks/encoding/Encoder.go
Generating mock for: Env in file: internal/mocks/env/Env.go
Generating mock for: FS in file: internal/mocks/fs/FS.go
Generating mock for: Handler in file: internal/mocks/cli/Handler.go
Generating mock for: Logger in file: internal/mocks/logging/Logger.go
Generating mock for: Storage in file: internal/mocks/logging/storage/Storage.go
# Checking the differences
make check_mocks 14.39s user 17.47s system 432% cpu 7.369 total
Reset the branch to origin/fix-check_mocks ✅
The following script should succeed:
$ git reset --hard origin/fix-check_mocks && make check_mocks
# Checking if mocks are up-to-date
# Removing existing mocks
# Generating new mocks
Generating mock for: CacheStore in file: mocks/providers/CacheStore.go
Generating mock for: Client in file: mocks/executors/winrm/Client.go
Generating mock for: Client in file: mocks/internal/orka/Client.go
Generating mock for: Encoder in file: mocks/internal/encoding/Encoder.go
Generating mock for: Env in file: mocks/internal/env/Env.go
Generating mock for: Executor in file: mocks/executors/Executor.go
Generating mock for: FS in file: mocks/internal/fs/FS.go
Generating mock for: Handler in file: mocks/internal/cli/Handler.go
Generating mock for: Logger in file: mocks/internal/logging/Logger.go
Generating mock for: Provider in file: mocks/providers/Provider.go
Generating mock for: Storage in file: mocks/internal/logging/storage/Storage.go
Generating mock for: customCommand in file: mocks/cmd/autoscaler/commands/custom/customCommand.go
Generating mock for: Client in file: internal/mocks/orka/Client.go
Generating mock for: Encoder in file: internal/mocks/encoding/Encoder.go
Generating mock for: Env in file: internal/mocks/env/Env.go
Generating mock for: FS in file: internal/mocks/fs/FS.go
Generating mock for: Handler in file: internal/mocks/cli/Handler.go
Generating mock for: Logger in file: internal/mocks/logging/Logger.go
Generating mock for: Storage in file: internal/mocks/logging/storage/Storage.go
# Checking the differences
Makefile | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
make: *** [check_mocks] Error 1
make check_mocks 14.28s user 17.77s system 430% cpu 7.444 total
Rename an interface argument to check that out-of-date mocks are still detected ✅
Rename vmInst
in providers/provider.go
to vmInstance
. The following script should fail:
$ make check_mocks
# Checking if mocks are up-to-date
# Removing existing mocks
# Generating new mocks
Generating mock for: CacheStore in file: mocks/providers/CacheStore.go
Generating mock for: Client in file: mocks/executors/winrm/Client.go
Generating mock for: Client in file: mocks/internal/orka/Client.go
Generating mock for: Encoder in file: mocks/internal/encoding/Encoder.go
Generating mock for: Env in file: mocks/internal/env/Env.go
Generating mock for: Executor in file: mocks/executors/Executor.go
Generating mock for: FS in file: mocks/internal/fs/FS.go
Generating mock for: Handler in file: mocks/internal/cli/Handler.go
Generating mock for: Logger in file: mocks/internal/logging/Logger.go
Generating mock for: Provider in file: mocks/providers/Provider.go
Generating mock for: Storage in file: mocks/internal/logging/storage/Storage.go
Generating mock for: customCommand in file: mocks/cmd/autoscaler/commands/custom/customCommand.go
Generating mock for: Client in file: internal/mocks/orka/Client.go
Generating mock for: Encoder in file: internal/mocks/encoding/Encoder.go
Generating mock for: Env in file: internal/mocks/env/Env.go
Generating mock for: FS in file: internal/mocks/fs/FS.go
Generating mock for: Handler in file: internal/mocks/cli/Handler.go
Generating mock for: Logger in file: internal/mocks/logging/Logger.go
Generating mock for: Storage in file: internal/mocks/logging/storage/Storage.go
# Checking the differences
mocks/providers/Provider.go | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
What are the relevant issue numbers?
Closes #57 (closed)
Edited by Pedro Pombeiro