Skip to content

Geo: `gdk doctor` is throwing a warning when Geo is enabled in primary GDK

What does this merge request do and why?

After !3387 (merged) in a primary GDK the geo database is not set. The gdk doctor diagnostic throws the following warning, even when Geo is enabled:

Geo
================================================================================
/Users/javieratapia/Desktop/gitlab-gdk/gdk/gitlab/config/database.yml contains the geo database settings but
geo.enabled is not set to true in your gdk.yml.

Either update your gdk.yml to set geo.enabled to true or remove
the geo database settings from /Users/javieratapia/Desktop/gitlab-gdk/gdk/gitlab/config/database.yml

https://gitlab.com/gitlab-org/gitlab-development-kit/blob/main/doc/howto/geo.md

This MR fixes that behavior when GDK is a Geo primary.

How to set up and validate locally

  • Follow this guide to setup Geo locally
  • Run gdk doctor in the primary GDK. It should not throw a warning.
  • Run gdk doctor in the secondary GDK. After deleting the development geo database in gitlab/database.yml it should throw a warning.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Closes #2031 (closed)

Edited by Javiera Tapia

Merge request reports

Loading