Skip to content

Rails5 fix Admin::HooksController

Jasper Maes requested to merge jlemaes/gitlab-ce:rails5-fix-48142 into master

What does this MR do?

Fix Admin::HooksController. default_value_for overwrites the attributes with the defaults if ActionController::Parameters are passed to SystemHook.new(hook_params). It works with a hash as argument.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #48142 (closed)

Edited by blackst0ne

Merge request reports

Loading