Skip to content

Prevents showing 2 tooltips in pipelines

Filipa Lacerda requested to merge 64608-double-tooltips into master

What does this MR do?

In this https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28865 the user's avatar and the commit title were wrapped in the tooltip-on-truncate component, which causes 2 different tooltips to rendered on hover.

This MR fixes that regression by moving the tooltip-on-truncate component to wrap the commit title only.

It also fixes the underline that was visible in the whitespace on hover and cleans up non-used CSS classes.

before after - firefox after - chrome
Screenshot_2019-08-06_at_10.20.57 Screenshot_2019-08-06_at_10.50.59 Screenshot_2019-08-06_at_10.51.33

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #64608 (closed)

Merge request reports

Loading