Skip to content

WIP: Handle submodules update before calling git lfs pull

Tomasz Maczukin requested to merge 4123-fix-git-lfs-support-for-submodules into 4123-refactor-get-sources-script-building

What does this MR do?

Changes ordering of submodules handling and git lfs pull execution.

Why was this MR needed?

  1. ~~To fix another regression created by !1200 (merged). Please read #4123 (closed) for context.~~
  2. Cleanup for !1298 (merged), which fixed the regression in 11.9.x
  3. Additionally current implementation that we have contains another bug - calling submodules without checking out the main repository will most probably generate a failure.

Reordering the calls for submodules update and git lfs pull should fix both problems.

Are there points in the code the reviewer needs to double check?

⚠ Prepared on top and blocked by !1298 (merged) and !1313 (merged) ⚠

⚠ Prepared on top of !1482 (closed). Requires it to be merged first ⚠

After merging !1482 (closed) we should change the target branch here to master and then un-WIP and merge this one.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Related to #4123 (closed)

Closes #4304 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports