Skip to content

feat(GlTab): Allow tab component to receive titleLinkClass props

David O'Regan requested to merge 994 into master

What does this MR do?

A small MVC for #994 (closed) to extend the GlTab to allow for the passing of an titleLinkClass prop for allowing class sets on the inner a tag within the GlTab.

We also extend the documentation and add some basic specs.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #994 (closed)

Edited by David O'Regan

Merge request reports

Loading