Skip to content

feat(GlTokenSelector): Add `textInputAttrs` prop

Peter Hegman requested to merge 1148-gltokenselector-add-a-textinputattrs-prop into master

What does this MR do?

Closes #1148 (closed)

When writing/migrating E2E QA specs sometimes we need the ability to add the data-qa-selector attribute to the text input of GlTokenSelector. Previously this was not possible but this MR adds a textInputAttrs prop that makes this possible.

This recently came up in gitlab!50701 (comment 490092228)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports