Skip to content

feat: keep clear-all button in token-selector at top right

What does this MR do?

This MR implements the proposal of #1868 (closed) by:

  • Wrapping the tokenContainer and the clear-all button in a seperate flex-container.
  • Fixing the alingment when the input wraps. You can notice wierd behavior in the gif in the issue: when the input in the container wraps onto the next row, the space at the top between tokens and container changes.

The implementation requires a defined width for the input field, otherwise the browser assumes a required min-width (for Firefox its around 200px), which results in overflowing the parent container. I've setteled with 40% width of the parent container (gl-w-40p). This behaves like a min-width of the input before flex wraps the input onto a new row. If it's on a new row, the input field grows. Maybe there is a better way of archiving this behavior.(?)

Solves #1868 (closed)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Marco Reinhold

Merge request reports

Loading