Skip to content

feat: Split up web-ide and workspaces patches

Paul Slaughter requested to merge ps-apply-web-ide-specific-patch into main

Issue: Do not apply Web IDE-specific patches to VSCode... (#44 - closed)

Description

This MR updates ./dev-apply-patches.sh and ./dev-save-patches.sh to receive an argument that specifies the context as either web-ide or workspaces.

  • The vscode-patches/ directory is now split up into vscode-patches/common/, vscode-patches/web-ide/
  • This resolves a number of issues where we tweak VSCode in a way that's only relevant in the Web IDE

Screenshots

Here's a video of me playing around with scripts/dev-save-patches.sh and scripts/dev-apply-patches.sh from within the vscode submodule:

patches_script_demo

Thanks

Thanks to @ealcantara @daniyalAD && @JoFletcher for pairing on this with me! 🎉

https://youtu.be/0Zg467GXbLI?si=8kR9QNsJYUuOykut

Edited by Paul Slaughter

Merge request reports