Skip to content

Add frontend for working with URL variables

Justin Ho Tuan Duong requested to merge 361125-webhook-encrypted-tokens-frontend-support-2 into master

What does this MR do and why?

This feature is behind the feature flag webhook_form_mask_url.

  • Properly mask the URL (as shown in the URL preview field) using simple logic (might need to be improved later on).
  • Add input handling to the mask item (bubbles up event to parent) and removing an item.
  • Add backend data for initial values to be populated (for when a user is editing a webhook).
MR Status
Add basic UI for UI masking of webhook URL (!99995 - merged) ✅ Merged
Add frontend for working with URL variables (!100817 - merged) 👈 You are here
Add frontend validations and handle editing of masked items 🚧 Coming soon

Screenshots or screen recordings

Webhooks_mask_URL

How to set up and validate locally

  1. Enable the feature flag.
  2. Go to Project > Settings > Webhooks. For example, http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/hooks.
  3. Use any URL as the webhook URL. For example, https://gitlab.com/dashboard/todos.
  4. Select Mask portions of the URL and add values. For example, gitlab.com -> domain, dashboard/todos -> path.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #361125 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports