Lazy load EE pipeline vue tabs
What does this MR do and why?
It adds lazy loading to the EE version of the new, Vue-based pipeline tabs. This prevents an issue in which components that get rendered as tab content are duplicated.
Related discussion: #381617 (comment 1163017252)
Screenshots or screen recordings
description | before | after |
---|---|---|
security tab: two modal instances | issue | Screen_Recording_2022-11-09_at_9.44.37_am |
security tab: browser error | ||
licenses tab: browser error |
How to set up and validate locally
- Enable feature flag:
echo "Feature.enable(:pipeline_tabs_vue)" | rails c
- Optional: Restart your local gdk (I needed this step in order to have the feature flag kick in)
- Navigate to a pipeline
- Click through the tabs
- Verify that the security tab's modals (when clicked on a finding) are working as expected
- Check the console to make sure no errors are thrown
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by David Pisek