Skip to content

Lazy load EE pipeline vue tabs

What does this MR do and why?

It adds lazy loading to the EE version of the new, Vue-based pipeline tabs. This prevents an issue in which components that get rendered as tab content are duplicated.

Related discussion: #381617 (comment 1163017252)

Screenshots or screen recordings

description before after
security tab: two modal instances issue Screen_Recording_2022-11-09_at_9.44.37_am
security tab: browser error Screen_Shot_2022-11-08_at_3.14.11_pm Screen_Shot_2022-11-09_at_9.45.07_am
licenses tab: browser error Screen_Shot_2022-11-08_at_3.14.38_pm Screen_Shot_2022-11-09_at_9.45.20_am

How to set up and validate locally

  1. Enable feature flag: echo "Feature.enable(:pipeline_tabs_vue)" | rails c
  2. Optional: Restart your local gdk (I needed this step in order to have the feature flag kick in)
  3. Navigate to a pipeline
  4. Click through the tabs
  5. Verify that the security tab's modals (when clicked on a finding) are working as expected
  6. Check the console to make sure no errors are thrown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Pisek

Merge request reports

Loading