Skip to content

Move timeout for markdown blobs into `OtherMarkup`

Brett Walker requested to merge 383442-revisit-timeout-for-all-markdown-blobs into master

What does this MR do and why?

Feature flag: :markup_rendering_timeout

We know that ruby's Timeout is a little unsafe. Rather than wrapping then entire Banzai pipeline in a Timeout call, we've started to target the specific Banzai filters that are having a problem. This way most of the pipeline can run and still produce usable results for the customer, and minimize and instabilities using Timeout.

We initially did this for the SyntaxHightlightFilter in !102819 (merged)

This MR moves the timeout that wrapped the entire blob markdown pipeline into OtherMarkup, so that any specific markup processor can't become a problem.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #383442 (closed)

Edited by Brett Walker

Merge request reports