Skip to content

Fix QA selector ID for vulnerability report filter dropdown items

Daniel Tian requested to merge 376342-fix-qa-selector-id into master

What does this MR do and why?

This MR does the following:

  1. Fixes an incorrect QA selector for the dropdown items for the vulnerability report project filter due to FilterItem not getting passed the text prop. Without it, it was using data-qa-selector="filter__dropdown", which was causing a QA test to fail: #385198 (closed)

  2. Fixes the QA selector incorrectly replacing names with multiple spaces, i.e. 'Some Item Name' -> filter_some item name_dropdown_item instead of filter_some_item_name_dropdown_item.

  3. Fixes the QA selector format, it was creating the string filter_item_name_dropdown, which is misleading because it's not the dropdown, it's the dropdown item.

  4. Changes the QA test to match the QA selector change mentioned above.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #376342 (closed)

Edited by Daniel Tian

Merge request reports