Resolve "Remove the `bulk_perform_and_wait` method"
What does this MR do and why?
Premise
If we look at the method definition of bulk_perform_and_wait
today, it is simply:
def bulk_perform_and_wait(args_list)
bulk_perform_async(args_list)
end
which means that even refreshes that are termed blocking
in the code is actually being processed like as non blocking
(aka async
) refresh behind the scenes since a while now (~6 months).
And hence, it is important that we bring this change to the forefront and also change the vocabulary in the actual code to reflect our transition to async refreshes everywhere, all the time
and this would be the final MR that completes our transition
This means that the concept of blocking
refreshes has to go away completely from the codebase, and hence the terms blocking
, blocking_refresh
and bulk_perform_and_wait
has to be removed, which is what this MR tries to accomplish.
Specs have also been adjusted accordingly as per this change. No changelog has been added as this is only a code refactor.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #383567 (closed)