Update to @gitlab/ui@59.0.0
requested to merge gitlab-ui-integration-2141-update-component-breadcrumb-based-on-navigation-redesign into master
What does this MR do and why?
Incorporates the changes from feat(Breadcrumb): Update design (gitlab-ui!3324 - merged) and makes any necessary adjustments to the 5 instances where the breadcrumb component is currently used.
-
app/assets/javascripts/packages_and_registries/harbor_registry/components/harbor_registry_breadcrumb.vue -
app/assets/javascripts/packages_and_registries/shared/components/registry_breadcrumb.vue -
app/assets/javascripts/vue_shared/new_namespace/new_namespace_page.vue -
ee/app/assets/javascripts/iterations/components/iteration_breadcrumb.vue -
ee/app/assets/javascripts/namespaces/verification/components/credit_card_verification.vue
Package | Type | Update | Change |
---|---|---|---|
@gitlab/ui | dependencies | major | 58.8.0 -> 59.0.0 |
Screenshots or screen recordings
📷 View before and after screenshots
Before | After | Notes |
---|---|---|
- | Used feature flag to view the after screenshot. No visual change. It's only the last item in the list that's using GlBreadcrumb. | |
No visual change. Per the note at the top of the template, only the last item is using GlBreadcrumb:// We are using gl-breadcrumb only at the last child of the handwritten breadcrumb until this gitlab-ui issue is resolved: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1079 gitlab-ui#1079 (closed) has been resolved, however. |
||
Padding and margin set to vertically center breadcrumbs with top row of new nav controls (based on design spec, not the current state of the nav). Border under breadcrumbs aligns with top of assignment buttons (applies to the other group and project pages too). The .container class was removed from around the main content so that the cards are as wide as the container (with the exception of a small amount of left and right margin from each card that's out of scope to change here). |
||
The .container class was removed from around the main content so that the cards are as wide as the container (with the exception of a small amount of left and right margin from each card that's out of scope to change here). |
||
No visual change. Per the note at the top of the template, only the last item is using GlBreadcrumb:// We are using gl-breadcrumb only at the last child of the handwritten breadcrumb until this gitlab-ui issue is resolved: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1079 gitlab-ui#1079 (closed) has been resolved, however. |
How to set up and validate locally
TBD
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Frédéric Caplette