Skip to content

Update to @gitlab/ui@59.0.0

What does this MR do and why?

Incorporates the changes from feat(Breadcrumb): Update design (gitlab-ui!3324 - merged) and makes any necessary adjustments to the 5 instances where the breadcrumb component is currently used.

Package Type Update Change
@gitlab/ui dependencies major 58.8.0 -> 59.0.0

Screenshots or screen recordings

📷 View before and after screenshots
Before After Notes
- 127.0.0.1_3000_jumbo-visma_test-harbor-project_-_harbor_repositories Used feature flag to view the after screenshot. No visual change. It's only the last item in the list that's using GlBreadcrumb.
gitlab.com_gitlab-org_gitlab_-packages_13047060__1 127.0.0.1_3000_gitlab-instance-ff060db2_Monitoring_-_packages No visual change. Per the note at the top of the template, only the last item is using GlBreadcrumb:

// We are using gl-breadcrumb only at the last child of the handwritten breadcrumb until this gitlab-ui issue is resolved: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1079

gitlab-ui#1079 (closed) has been resolved, however.

CleanShot_2023-03-09_at_15.51.07_2x
gitlab.com_groups_new 127.0.0.1_3000_groups_new Padding and margin set to vertically center breadcrumbs with top row of new nav controls (based on design spec, not the current state of the nav). Border under breadcrumbs aligns with top of assignment buttons (applies to the other group and project pages too).

The .container class was removed from around the main content so that the cards are as wide as the container (with the exception of a small amount of left and right margin from each card that's out of scope to change here).
gitlab.com_groups_new__2_ 127.0.0.1_3000_groups_new__1_
gitlab.com_projects_new__1_ 127.0.0.1_3000_projects_new The .container class was removed from around the main content so that the cards are as wide as the container (with the exception of a small amount of left and right margin from each card that's out of scope to change here).
gitlab.com_projects_new 127.0.0.1_3000_projects_new__1_
gitlab.com_groups_new_parent_id_64992960 127.0.0.1_3000_groups_new_parent_id_75
gitlab.com_gitlab-org_gitlab_-_cadences 127.0.0.1_3000_groups_jumbo-visma_-_cadences__createdCadenceId_8001 No visual change. Per the note at the top of the template, only the last item is using GlBreadcrumb:

// We are using gl-breadcrumb only at the last child of the handwritten breadcrumb until this gitlab-ui issue is resolved: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1079

gitlab-ui#1079 (closed) has been resolved, however.

CleanShot_2023-03-08_at_22.52.06_2x

How to set up and validate locally

TBD

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Frédéric Caplette

Merge request reports

Loading