Skip to content

Require disable_ddl_transaction on bbm finalization

Marius Bobin requested to merge 396351-no-ddl-transaction-for-batch-migrations into master

What does this MR do and why?

ensure_batched_background_migration_is_finished will call finalize_batched_background_migration to complete the background migrations, but that call may be skipped if the migration is already complete. In finalize_batched_background_migration we check that the DDL transaction is disabled, but on .com that check might not be executed if the method is not called. Now I'm adding it to the ensure_batched_background_migration_is_finished method too so that it will fail during development if the DDL transaction is not disabled.

Related to !114483 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396351 (closed)

Edited by Marius Bobin

Merge request reports