Resolve trial maintenance issues with helper
What does this MR do and why?
broken off from work in !115567 (merged)
- Move helper from
ee
subdirectory as there is nofoss
equivalent, so putting it where it should be. - Pluralize the helper name to match naming with controller and convention.
- resolve rubocop issues that are easy wins.
- wrapped some lines for smaller screens/ease of reading in IDE(max 120 columns)
- removed some double quotes in favor of single quotes... I know, I know...but rubymine was yelling at me, otherwise I wouldn't care.
- changed some url helpers to use
_path
instead of_url
as we are in the product and there is no need for full URL. We should be intentional when we use_url
over_path
as it implies something about that area.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393969 (closed)
Edited by Doug Stull