Added reveal/hide password input to all login pages
What does this MR do and why?
This is part of the work required for #394803 (closed). Previous work made the password input reuseable, which can be seen here: !119635 (merged).
This MR adds the reveal/hide password input to all login pages.
Specifically, it added the password input to the following locations:
- Regular login page
- Admin Mode Login
- LDAP Login
- Crowd Login
Screenshots or screen recordings
Regular Login
Before | After |
---|---|
![]() |
![]() |
Admin Mode Login
Before | After |
---|---|
![]() |
![]() |
LDAP Login
Before | After |
---|---|
![]() |
![]() |
Crowd Login
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Normal Login
- Navigate to
http://gdk.test:3000/users/sign_in
- Check the password field
Admin Mode Login
- Sign in as admin
- Navigate to
http://gdk.test:3000/admin/session/new
- Check the password field
LDAP Login
LDAP Setup
To setup LDAP locally, add the following to your config/gitlab.yml
file:
development:
ldap:
enabled: true
servers:
main:
label: ldap
host: 127.0.0.1
port: 3890
uid: 'uid'
encryption: 'plain' # "start_tls" or "simple_tls" or "plain"
base: 'dc=example,dc=com'
user_filter: ''
group_base: 'ou=groups,dc=example,dc=com'
admin_group: ''
- After updating
config/gitlab.yml
, restart gdk - Navigate to
http://gdk.test:3000/users/sign_in
- Select LDAP tab
- Check the password field
Crowd Login
Crowd Setup
To setup Crowd locally, add the following to your config/gitlab.yml
file:
development:
omniauth:
providers:
# Other providers here...
- { name: 'crowd',
args: {
crowd_server_url: 'http://127.0.0.1:3890',
application_name: 'Crowd',
application_password: 'YOUR_APP_PASSWORD' } }
- After updating
config/gitlab.yml
, restart gdk - Navigate to
http://gdk.test:3000/users/sign_in
- Select Crowd tab
- Check the password field
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #394803 (closed)
Edited by Ross Byrne