Skip to content

Observe async MR preparation to dynamically load the diffs content

Thomas Randolph requested to merge tor/feature/subscribe-to-mr-updates-on-changes-tab into master

What does this MR do and why?

For #398557 (closed)

When an MR is being prepared asynchronously, the changes in this MR listen for that preparation and then refresh the content when it is ready.
This avoids user confusion and a poor UX.

Notably, the code changes here prepare the Code Review part of the app (Notes, Diffs, any future things) to share a single signaling infrastructure.

Screenshots or screen recordings

There is no before because the "before" is just an indefinite spinner and no UI changes.

With the changes in this branch, it looks like:

RecApp-2023-05-11-23_24_05

How to set up and validate locally

  1. Add sleep(1.minute) here
  2. Create a new MR
  3. Once you create the MR, immediately switch to the Changes tab
  4. Wait for ~1 minute

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Randolph

Merge request reports