Skip to content

Makes RuleScheduleService inherit from BaseProjectService

Niku Singh requested to merge gitlab-community/gitlab:issue#414387 into master

What does this MR do and why?

This MR solves #414387 (closed) by making changes to the files as suggested #414387 (comment 1425986360).

Changes that have been made

RuleScheduleService is now inherited from BaseProjectService whereas earlier it was inherited from BaseContainerService. Also the callers of RuleScheduleService have been updated to pass project instead of container.

Questions

  1. What difference does making RuleScheduleService inherit from BaseProjectService make?
  2. What would have happened if we had stuck to the old codebase?

Screenshots or screen recordings

I create a scheduled scan execution policy following these steps with a cadence

Screenshot_from_2023-06-14_19-25-07Screenshot_from_2023-06-14_19-25-12

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Niku Singh

Merge request reports

Loading