Standalone modal - fix rendering of request and response sections
What does this MR do and why?
Fix the behaviour of the request/response rendering, so it is aligned with the current modal:
- The request section should not render if there is no
method
,url
orheaders
data - The response section should not render if there is no
statusCode
orheaders
data
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
Setup
- Have the related FF enabled:
echo "Feature.enable(:standalone_finding_modal)" | rails c
- You'll need an EE License
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validation
- Go to the pipeline's security report tab
- Set Filter: Tool -> DAST
- Click on the finding with the title "CWE-16 in" and verify that the request/response section is showing
- Click on the other DAST findings and verify that the request/response sections are not showing
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #416352 (closed)
Edited by David Pisek