Resolve tooltip on navigation toggle button staying visible on mobile
What does this MR do and why?
Resolve tooltip staying open on touch devices where touch triggers mouseover
on <super-sidebar-toggle>
:
- Use
type
prop to compute expand/collapse tooltiptitle
/container
/placement
- Remove
tooltipContainer
andtooltipPlacement
props - Remove
tooltipTitle
computed prop - Add
mounted
handler forbv::tooltip::show
(discussion: #408761 (comment 1565142901)) - Rename
canOpen
toisTypeExpand
- Compute
aria-expanded
onisTypeCollapse
- Remove
sidebarState
parameter fromcreateWrapper
function in spec tests
Screenshots or screen recordings
Before | After |
---|---|
RPReplay_Final1695190441 | RPReplay_Final1695193044 |
How to set up and validate locally
- Review new navigation toggle button on desktop (mouse) and mobile (touch) devices
- Toggle sidebar with button
- Tooltip should not display on touch event
- All other states for navigation should be unaffected:
- Expanded
- Collapsed
- Collapsed peek on left of viewport
- Collapsed peek on button mouseover
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #408761 (closed)
Edited by Scott de Jonge