Skip to content

Resolve tooltip on navigation toggle button staying visible on mobile

What does this MR do and why?

Resolve tooltip staying open on touch devices where touch triggers mouseover on <super-sidebar-toggle>:

  • Use type prop to compute expand/collapse tooltip title/container/placement
  • Remove tooltipContainer and tooltipPlacement props
  • Remove tooltipTitle computed prop
  • Add mounted handler for bv::tooltip::show (discussion: #408761 (comment 1565142901))
  • Rename canOpen to isTypeExpand
  • Compute aria-expanded on isTypeCollapse
  • Remove sidebarState parameter from createWrapper function in spec tests

Screenshots or screen recordings

Before After
RPReplay_Final1695190441 RPReplay_Final1695193044

How to set up and validate locally

  1. Review new navigation toggle button on desktop (mouse) and mobile (touch) devices
  2. Toggle sidebar with button
  3. Tooltip should not display on touch event
  4. All other states for navigation should be unaffected:
    1. Expanded
    2. Collapsed
    3. Collapsed peek on left of viewport
    4. Collapsed peek on button mouseover

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #408761 (closed)

Edited by Scott de Jonge

Merge request reports

Loading