Skip to content

Fix Markdown rendering references inside inline diff

Paul Slaughter requested to merge ps-markdown-render-refs-under-idiff into master

What does this MR do and why?

This MR updates the markdown renderer so that references are not rendered inside inline diffs.

See this issue for context, where a random user @G- was pinged when the MR title was updated.

Screenshots or screen recordings

Before After
Screenshot_2023-09-20_at_7.40.00_PM Screenshot_2023-09-20_at_7.40.46_PM

How to set up and validate locally

  1. Run GDK with the changes on this branch.
  2. Visit an issue.
  3. Write a comment with {+ @test +} and click "Preview"
  4. Confirm that the @test reference isn't added.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Paul Slaughter

Merge request reports

Loading