Migrate table class in /chat_names/index.html.haml to gl-table
requested to merge 426228-migrate-table-class-haml-in-app-views-profiles-chat_names-index-html-haml into master
What does this MR do and why?
Migrates the table class in https://gitlab.com/gitlab-org/gitlab/-/blob/7e041c4d46008bc4cb60234b8df4b5f983340b0d/app/views/profiles/chat_names/index.html.haml to gl-table
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
Go to http://127.0.0.1:3000/-/profile/chat_names
and apply the following diff to force render the page:
diff --git a/app/views/profiles/chat_names/_chat_name.html.haml b/app/views/profiles/chat_names/_chat_name.html.haml
index 0ac8ede3c621..d9a96b1b985d 100644
--- a/app/views/profiles/chat_names/_chat_name.html.haml
+++ b/app/views/profiles/chat_names/_chat_name.html.haml
@@ -10,4 +10,4 @@
= _('Never')
%td
- = link_button_to _('Remove'), profile_chat_name_path(chat_name), method: :delete, class: 'float-right', aria: { label: _('Remove') }, data: { confirm: _('Are you sure you want to remove this nickname?'), confirm_btn_variant: 'danger' }, variant: :danger
+ = link_button_to _('Remove'), profile_chat_name_path(id: 1), method: :delete, class: 'float-right', aria: { label: _('Remove') }, data: { confirm: _('Are you sure you want to remove this nickname?'), confirm_btn_variant: 'danger' }, variant: :danger
diff --git a/app/views/profiles/chat_names/index.html.haml b/app/views/profiles/chat_names/index.html.haml
index 99284abb73da..f1e529d0d882 100644
--- a/app/views/profiles/chat_names/index.html.haml
+++ b/app/views/profiles/chat_names/index.html.haml
@@ -1,7 +1,7 @@
- page_title _('Chat')
- @hide_search_settings = true
- @force_desktop_expanded_sidebar = true
-
+- @chat_names = [ChatName.new({ user: User.first, team_domain: 'foo', chat_name: 'bar', last_used_at: 1.week.ago })]
.settings-section.js-search-settings-section.gl-mt-3
.settings-sticky-header
.settings-sticky-header-inner
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #426228
Edited by Justin Ho Tuan Duong