Skip to content

Fix Artifacts browse page breadcrumbs

Deepika Guliani requested to merge dg-fix-artifacts-breadcrumbs into master

What does this MR do and why?

Import projects.scss on Artifacts browse page as well after Import missing projects specific CSS on more li... (!131405 - merged) was merged. Issue is only visible to gitlab_team_members

Screenshots or screen recordings

I could not verify artifacts on my local environment but can confirm that it is not included on job artifacts browse page on gitlab.com when FF :page_specific_styles is on

Before see that projects.scss is not included in head header
Screenshot_2023-10-19_at_5.12.00_PM -

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In rails console enable the experiment fully
    Feature.enable(:page_specific_styles)
  2. Visit any group or project member pages such as http://127.0.0.1:3000/groups/flightjs/-/group_members
  3. Click on Build -> Jobs ( in left sidebar )
  4. Click any Job detail page
  5. See Job Artifacts Browse button as shown in the image Screenshot_2023-10-19_at_5.14.12_PM
  6. See that the breadcrumbs are fixed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Angelo Gulina

Merge request reports

Loading