Skip to content

Switch specs shared example to use the new navigation

Thomas Hutterer requested to merge thutterer/switch-specs-to-new-nav-4 into master

What does this MR do and why?

As part of #420121 (closed) this MR switches some features specs to run with the new "super sidebar" navigation, instead of the old one.

We are doing this in batches, and this batch switches all spec files that used the 'a "Your work" page with sidebar and breadcrumbs' shared example.

Furthermore, as the only change in the app/, we now serialize an id for every Menu object. This was still missing on menu objects, we only had it for menu items.

Screenshots or screen recordings

No visual or functional change.

How to set up and validate locally

  • Check CI and/or run a couple of the updated feature specs locally with WEBDRIVER_HEADLESS=0 bundle exec rspec to see the new nav being used.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports