Skip to content

Licensed VSA UI visibility enhancements

Adam Hegyi requested to merge 414794-vsa-guest-role-refinement into master

What does this MR do and why?

This MR adjusts the paid project level Value Stream Analytics visibility and exposes it publicly if the project is public. Additionally, the change removes the edit and delete buttons if the user has no permission.

For extra security, we use the Issuable finder for loading related records which correctly applies the visibility rules.

Screenshots or screen recordings

When guest user visits a public licensed project with VSA where VSA is not configured yet. (The create value stream button is hidden)

image

When guest user visits a public licensed project with VSA. Edit/delete actions are disabled.

{{image.png}}

How to set up and validate locally

Case 1:

  1. Ensure that you're on Premium or on Ultimate.
  2. Create a new group and project (public visibility).
  3. Create a registered user (not member of the group or project).
  4. Visit the project and go: Analyze > Value stream analytics.
  5. You should see the the same screen as on the first screenshot. No ability to create a value stream.

Case 2:

  1. As a member of the previously created project, create a value stream with stages.
  2. As the previous user, visit the Value stream analytics page.
  3. You should see the the same screen as on the second screenshot.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414794 (closed)

Edited by Adam Hegyi

Merge request reports