Skip to content

Migrate deprecated sorting-item component in dependencies_actions

Taras Tadai requested to merge gitlab-community/gitlab:438434-migrate-sorting-item-in-dep-actions into master

What does this MR do and why?

Removed gl-sorting-item in ee/app/assets/javascripts/dependencies/components/dependencies_actions.vue as it's deprecated. New way to use it is to pass :sort-options=.

It's a part of Pajamas adoption project

Epic: &11924 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
dependencies_actions_old dependencies_actions_new

How to set up and validate locally

  1. Open some project
  2. Goto Security -> Dependency list https://docs.gitlab.com/ee/user/application_security/dependency_list/ (Ultimate)
  3. Use sorting component

To see the UI on empty list you may return false here: https://gitlab.com/gitlab-org/gitlab/-/blob/216d95db7412b56f2dab4d63aa0b57ee97fe34ae/ee/app/assets/javascripts/dependencies/components/app.vue#L88

Related to #438434 (closed)

Edited by Taras Tadai

Merge request reports