Skip to content

Fix creation of instance-level member roles

Hinam Mehra requested to merge 439161-fix-instance-level-custom-roles into master

What does this MR do and why?

  • There were some recent backend changed merged that broke instance-level member role creating because the GraphQL was sending groupPath: null.
  • In this MR, we are removing the groupPath key from the GraphQL query when creating instance-level member roles.
  • I have also added feature specs to make sure any changes like this get caught.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. Turn off SaaS mode with:
export GITLAB_SIMULATE_SAAS=0
  1. Log-in as admin and navigate to /admin/application_settings/roles_and_permissions
  2. Click on Add new role

Related to #439161 (closed)

Edited by Hinam Mehra

Merge request reports