Hide keyboard shortcuts in tooltips when disabled
What does this MR do and why?
Hide keyboard shortcuts in tooltips when that user preference is disabled.
Follows approach from !140979 (merged), and applies it to the changes in !141526 (merged), !141154 (merged), and !140965 (merged)
Additionally:
- Sanitize HTML in tooltips
- Use
keysFor
function to get shortcut keys
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Location | Shortcuts disabled | Shortcuts enabled |
---|---|---|
Issue | ||
Epic | ||
Repository folder | ||
Repository file |
How to set up and validate locally
Do these steps with keyboard shortcuts enabled and disabled:
- Visit an issue and hover/focus
- “Edit” button
- “Edit” button for assignee
- “Edit” button for labels
- Visit an epic and hover/focus
- “Edit” button“
- “Edit” button for labels
- Open the repository view or a specific folder, select the “Edit” dropdown, and see the Web IDE option
- Open a file in the repository and see the Web IDE option
Edited by Pedro Moreira da Silva