Skip to content

Hide keyboard shortcuts in tooltips when disabled

Pedro Moreira da Silva requested to merge pms-improve-keyshortcuts-tooltips into master

What does this MR do and why?

Hide keyboard shortcuts in tooltips when that user preference is disabled.

Follows approach from !140979 (merged), and applies it to the changes in !141526 (merged), !141154 (merged), and !140965 (merged)

Additionally:

  • Sanitize HTML in tooltips
  • Use keysFor function to get shortcut keys

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Location Shortcuts disabled Shortcuts enabled
Issue

image.png

CleanShot 20240110172557.mp4

CleanShot 20240110120949.mp4

CleanShot 20240110120640.png

CleanShot 20240110120648.png

Epic

image.png

CleanShot 20240110172635.mp4

CleanShot 20240110120656.png

Repository folder

CleanShot 20240103172641@2x.png

CleanShot 20240103172330@2x.png

Repository file

CleanShot 20240103172629@2x.png

CleanShot 20240103172425@2x.png

How to set up and validate locally

Do these steps with keyboard shortcuts enabled and disabled:

  1. Visit an issue and hover/focus
    1. “Edit” button
    2. “Edit” button for assignee
    3. “Edit” button for labels
  2. Visit an epic and hover/focus
    1. “Edit” button“
    2. “Edit” button for labels
  3. Open the repository view or a specific folder, select the “Edit” dropdown, and see the Web IDE option
  4. Open a file in the repository and see the Web IDE option
Edited by Pedro Moreira da Silva

Merge request reports

Loading