Skip to content

Update split i18n strings to be more translatable

Chad Lavimoniere requested to merge 450712-undo-the-split-sentence-in-because-reason-to-make-text-localizable into master

What does this MR do and why?

Update the format of i18n strings that have multiple parts formatted into an English language sentence so that they can be translated into other languages that don't use similar syntax.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

This is a difficult set of changes to test in the GDK, as they range widely.

For most changes, the change is only a change in the copy the user sees and has no mechanical/functional change. These changes have already undergone Technical Writing review.

Mechanically, I think special reviewer scrutiny is probably due to my changes in app/helpers/emails_helper.rb and its spec file /spec/helpers/emails_helper_spec.rb. Previously, this file only returned the reason part of a split internationalized string, but I have changed it to return the entire message.

These changes can be most conveniently reviewed by visiting the mailer preview app (http://gdk.test:3000/rails/mailers) and checking the contents of generated emails.

Emails impacted by my changes:

Related to #450712 (closed), #444717 (closed)

Edited by Chad Lavimoniere

Merge request reports